Fix trigger in Zabbix 4.0 LTS, add support to systemd 219 (CentOS 7) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tested this in systemd version 219. To be honest the script marked as "old" is also compatible with recent systemd versions, but I'm not bold enough to rewrite that. Again: this change does NOT change any already-in-use script.
The template of Zabbix version 4.0 LTS checks the wrong systemd status value. The value is supposed to be: - 1 if the service is running - 0 if the service is NOT running And in fact the template of version 5.0 checks that, since it checks last()=0. Instead, the template of version 4.0 checks if last()<>0. This change has NO impact on the template 5.0.
valerio-bozzolan
commented
Feb 2, 2023
| # Don't alert if the server has just been restarted | ||
| uptime=$(date +%s -d "$(systemctl show --value -p ActiveEnterTimestamp sysinit.target)") | ||
| uptime=$(date +%s -d "$uptime_value") |
There was a problem hiding this comment.
I've just extracted the variable
valerio-bozzolan
commented
Feb 2, 2023
| @@ -195,7 +195,7 @@ | |||
| <tags/> | |||
| </trigger_prototype> | |||
| <trigger_prototype> | |||
| <expression>{SystemD service monitoring template:systemd.service.status[{#SERVICE}].last()}<>0</expression> | |||
| <expression>{SystemD service monitoring template:systemd.service.status[{#SERVICE}].last()}=0</expression> | |||
There was a problem hiding this comment.
Now Zabbix 4 checks the last()=0. Note that Zabbix 5 also checks that:
I don't know why v4 was last()<>0. Probably the related v4 script had different return values than the current version. By the way now it's correct (1 = running, 0 = stopped).
|
Do you have any question? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this pull request (batteries included):
I've splitted my pull request in multiple very small commits to help maintainer in reviewing.
NOTE: I've NOT modified the template of version 5 or the scripts for version 5. If you want, you can test my scripts also in a recent version and I think it will work, so you can adopt my "old" scripts for both versions. But, to be more friendly, I have not taken this decision for you, so I'm keeping both.
Thank you :)